Skip to content
This repository was archived by the owner on Aug 3, 2024. It is now read-only.

Forbid spaces in anchors (#1148) #1151

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Forbid spaces in anchors (#1148) #1151

merged 1 commit into from
Mar 29, 2020

Conversation

Lysxia
Copy link
Contributor

@Lysxia Lysxia commented Mar 29, 2020

Closes #1148

@harpocrates
Copy link
Collaborator

There appears to be another test for the wrong behaviour which is causing CI to fail. You'll have to update that test so CI passes. I propose: rename the test to "doesn't parse a multi word anchor" and include a link to the HTML spec in a comment right above the test. 😄

@Lysxia Lysxia force-pushed the no-space-a branch 2 times, most recently from 37e8ab1 to d604edd Compare March 29, 2020 19:41
@Lysxia
Copy link
Contributor Author

Lysxia commented Mar 29, 2020

Thanks for the suggestion :) Done!

@harpocrates harpocrates merged commit 4f53694 into haskell:ghc-8.8 Mar 29, 2020
@harpocrates
Copy link
Collaborator

Thanks for your contribution! 👍

PS. Travis CI has been flaky at updating statuses after finishing. Looking directly on the Travis CI website, this PR passed CI.

@Lysxia Lysxia deleted the no-space-a branch March 29, 2020 22:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse pragmas in @@ blocks
2 participants
@Lysxia @harpocrates